Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update valine.swig #1934

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Update valine.swig #1934

merged 1 commit into from
Oct 11, 2017

Conversation

Aqua-Dream
Copy link
Contributor

@Aqua-Dream Aqua-Dream commented Oct 11, 2017

New valine version released.
"#vcomment" does not work because the id of comment element is "comment", so it should be modified by "#comment".

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): #1933

What is the new behavior?

Now valine can work.

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

N/A

Does this PR introduce a breaking change?

  • Yes.
  • No.

New valine version released.
"#vcomment" does not work.
@ivan-nginx ivan-nginx merged commit 885633d into iissnan:master Oct 11, 2017
@ivan-nginx
Copy link
Collaborator

Thanks!

@ivan-nginx ivan-nginx added this to the v5.1.4 milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants